Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x] test: skip testing --watch with --import #44530

Closed
wants to merge 4 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 6, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 6, 2022
@MoLow
Copy link
Member Author

MoLow commented Sep 6, 2022

cc @nodejs/releasers @RafaelGSS

@aduh95 aduh95 changed the title test: skip testing --watch with --import [v18.x] test: skip testing --watch with --import Sep 6, 2022
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

tniessen and others added 4 commits September 7, 2022 15:33
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
PR-URL: nodejs#44402
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#44045
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#44366
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
Copy link
Member Author

MoLow commented Sep 7, 2022

closing. will backport the entire --watch feature once #44521 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants